Skip to content

Conversation

@tshepang
Copy link
Member

I don't understand what "not (only) rustdoc" means

@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2025

Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using r? rustc-dev-guide or r? <username>.

@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Aug 29, 2025
jyn514
jyn514 previously requested changes Aug 29, 2025
@tshepang
Copy link
Member Author

tshepang commented Aug 30, 2025

@fmease are you happy with latest change

@fmease
Copy link
Member

fmease commented Aug 31, 2025

[@]fmease are you happy with latest change

That's already miles better, thank you! It's still not quite correct (see inline review comment).

@tshepang
Copy link
Member Author

am happy if you can push directly to the pr... I imagine you can

@jieyouxu
Copy link
Member

r? fmease

@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2025

⚠️ Warning ⚠️

@BoxyUwU
Copy link
Member

BoxyUwU commented Dec 11, 2025

do we really block merging to dev guide based off any changes requested... thats...

@tshepang tshepang merged commit 7d6e412 into main Dec 11, 2025
1 check passed
@rustbot rustbot removed the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Dec 11, 2025
@tshepang tshepang deleted the tshepang-patch-1 branch December 11, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants